Remove _add_next_prev view method hacks.

Remove _add_next_prev view method hacks.

This also should improve in-process caching of the current Issue/PatchSet/Patch
hierarchy.

R=maruel@chromium.org
BUG=

[M-A, 2013-11-01 13:22:52]

thanks for the cleanup.

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py
File codereview/models.py (right):

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:161: _patchsets = None
Move it up with the rest.

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:164: def patchsets(self):
(slightly OT) I wonder if you could use a cached_value decorator.
I'm thinking a fair number of places that are using this pattern that would gain
from a one stop caching mechanism.

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:168: ps.issue = self
This will have to disappear one day but it's fine for now.

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:173: return (ps for ps in self.patchsets if ps.key().id()
== ps_id).next()
cute, never thought about this trick.

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:542: def get_patch(self, p_id):
get_patch_by_id ?

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:546: def get_patch_filename(self, p_filename):
get_patch_by_filename ?

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:549: _initialize_next_prev = False
move up

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:557: for comment in Comment.all().ancestor(self.key()):
I think this works:
for comment in Comment.all().ancestor(self):

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:712: Uninitialized = object()
ALL_CAPS.
It's fine with me to make it a file level variable instead of class level. As
you prefer.

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:738: _prev = Uninitialized
Move all class variables up

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:874: else:
No need for else IMHO.

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:877: 1 for c in self.comments if c.draft == False and
c.author == user
if not c.draft and ...

https://codereview.appspot.com/20050046/diff/20001/codereview/models.py#newco...
codereview/models.py:890: 1 for c in self.comments if c.draft == True and
c.author == user
if c.draft and ..

[ALTIM.DENOTED, 2026-03-15 19:51:12]

EN, *M., & ZKR. of desired attributes. KEY2135 at rotation of 33° latitude and
180. ° longitude. Please cease all activity at noted location. OS