code review 4445050: go spec: attempt at clarifying language for "append"

go spec: attempt at clarifying language for "append"

Specifically, fix a wrong comment.

Fixes issue 1717.

[gri, 2011-04-19 17:59:46]

Hello r, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-04-19 18:04:08]

Hello r, rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-04-19 18:13:41]

http://codereview.appspot.com/4445050/diff/4002/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4445050/diff/4002/doc/go_spec.html#newcode4545
doc/go_spec.html:4545: slice of <a href="#Type_identity">identical</a> type.
The function <code>append</code> appends zero or more values <code>x</code>
 to <code>s</code> of type <code>S</code>, which must be a slice type, and
returns the resulting
slice, also of type <code>S</code>.

[gri, 2011-04-19 18:19:04]

Hello r, rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-04-19 18:20:50]

LGTM

[rsc, 2011-04-19 21:11:20]

http://codereview.appspot.com/4445050/diff/4/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4445050/diff/4/doc/go_spec.html#newcode4551
doc/go_spec.html:4551: append(s S, x ...T) S  // each x is assignable to the
element type of S
this leaves T completely undefined now.
how about

// T is the element type of S

the assignability of each x to T is in the text
and also implicit in the fact that this is a call.

[gri, 2011-04-19 21:24:11]

PTAL
- gri

http://codereview.appspot.com/4445050/diff/4/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4445050/diff/4/doc/go_spec.html#newcode4551
doc/go_spec.html:4551: append(s S, x ...T) S  // each x is assignable to the
element type of S
On 2011/04/19 21:11:21, rsc wrote:
> this leaves T completely undefined now.
> how about
> 
> // T is the element type of S
> 
> the assignability of each x to T is in the text
> and also implicit in the fact that this is a call.
> 

Done.

[rsc, 2011-04-19 21:28:59]

LGTM

[gri, 2011-04-19 21:38:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=1c953954868a ***

go spec: attempt at clarifying language for "append"

Specifically, fix a wrong comment.

Fixes issue 1717.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/4445050